-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree-sitter: 0.24.6 -> 0.25.1 #379367
base: staging
Are you sure you want to change the base?
tree-sitter: 0.24.6 -> 0.25.1 #379367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so much a blocker, if you don't mind though, could you update the grammars?
Cheers :^)
@amadaluzia as mentioned in the description, I couldn't run the update script for the grammars due to rate limiting on my computer, despite the token. |
Oh, just saw that now. I'll see if I can update the grammars. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5187 |
@amadaluzia friendly ping. |
Hey there! I got caught up externally but I should be able to properly update this now. |
Things done
Release notes: https://github.com/tree-sitter/tree-sitter/releases/tag/v0.25.1
I couldn't update the grammars, first because of the wrong token environment variable, and then because I still got rate limited on the computer I used to run the update.
I'll say that I expect a lot of churn on the patch file to disable the playground, compared to when it used to just
substituteInPlace
a few lines.nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.