Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdenv: disable hardening for embedded (kernel=none) targets #378825

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

midnightveil
Copy link
Contributor

A very partial fix for #18995. This should make the relatively common case of embedded targets Just Work™, since these systems rarely are setup in the standard way.

I've often seen __stack__chk failures when building for embedded systems, enabling this should make these architectures usable without needing to do crimes in nix shells / build environments.


DRAFT, because I need to make sure this works as expected, i.e. I can build things without adding hardeningDisable to nix-shells for embedded work.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

cc @wucke13 since this might be of shared interest

A very partial fix for [NixOS#18995]. This should make the relatively
common case of embedded targets Just Work™, since these systems rarely
are setup in the standard way.

I've often seen __stack__chk failures when building for embedded systems,
enabling this should make these architectures usable without needing
to do crimes in nix shells / build environments.

[NixOS#18995]: NixOS#18995
@wucke13
Copy link
Contributor

wucke13 commented Feb 2, 2025

@midnightveil Thank you! I do this all the time for embedded targets, this is a net positive in usability of Nix for niche target environments

@midnightveil
Copy link
Contributor Author

midnightveil commented Feb 2, 2025

@midnightveil Thank you! I do this all the time for embedded targets, this is a net positive in usability of Nix for niche target environments

Yep, I know :)

I have a suspicion that it might need to be targetPlatform instead of hostPlatform (or that it might not work since the mkShell is usually a non-cross stdenv and might override the compiler)... unfortunately it rebuilds the universe since it modifies most of the target's packages which will take a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants