Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust-hypervisor-firmware: 0.4.2 -> 0.5.0 #378694

Merged
merged 1 commit into from
Feb 5, 2025
Merged

rust-hypervisor-firmware: 0.4.2 -> 0.5.0 #378694

merged 1 commit into from
Feb 5, 2025

Conversation

astro
Copy link
Contributor

@astro astro commented Feb 2, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 2, 2025
@astro astro force-pushed the rust-hypervisor-firmware branch from 43b8336 to 95ba586 Compare February 3, 2025 01:07
@astro astro requested a review from ethancedwards8 February 3, 2025 01:07
@astro astro requested a review from alyssais February 4, 2025 18:38
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 4, 2025
@astro astro force-pushed the rust-hypervisor-firmware branch from 95ba586 to bd37a0f Compare February 5, 2025 00:39
@astro astro requested a review from SuperSandro2000 February 5, 2025 00:39
@SuperSandro2000 SuperSandro2000 mentioned this pull request Feb 5, 2025
Open
13 tasks
@SuperSandro2000
Copy link
Member

builds locally and with #379671 it builds without setting NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1

@SuperSandro2000 SuperSandro2000 merged commit 1bffa9f into NixOS:master Feb 5, 2025
25 of 27 checks passed
@astro astro deleted the rust-hypervisor-firmware branch February 10, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@astro @SuperSandro2000 @ethancedwards8 @wegank