parted: backport upstream C23 fix #378578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the change the build against c23 compiler (like `gcc-15`) fails as:
parted> parted.c: In function '_init_commands':
parted> parted.c:2469:9: error: passing argument 2 of 'command_create' from incompatible pointer type []
parted> 2469 | do_version,
parted> | ^~~~~~~~~~
parted> | |
parted> | int (*)(void)
github-actions
bot
added
10.rebuild-darwin: 0
Yarny0
approved these changes
Feb 2, 2025
There was a problem hiding this comment.
Tested after merging with current nixos-unstable:
- Created/modified lots of partitions with
pyparted. This isn'tparted, butpartedis a dependency ofpyparted. So that suggests that thepartedfunctionality still works, even when compiled withenableParallelBuilding. - Shell command
parted --versionworks as expected. That's likely the code that is affected by the new patch.
So, in essence, I tested most of parted functionality only indirectly, but those things still seem to work as expected.
nixpkgs-review wants to rebuild more that 1000 packages, so I didn't do that.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2230 |
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the change the build against c23 compiler (like
gcc-15) fails as:Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.