Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gaphor: 2.27.0 -> 3.0.0 #378026

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

gaphor: 2.27.0 -> 3.0.0 #378026

wants to merge 1 commit into from
+2 −2

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Jan 30, 2025

Diff: gaphor/gaphor@2.27.0...3.0.0

Changelog: https://github.com/gaphor/gaphor/releases/tag/3.0.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo getchoo added 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically labels Jan 30, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1 10.rebuild-linux: 1-10 labels Jan 30, 2025
@nbraud
Copy link
Contributor

nbraud commented Feb 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 378026

x86_64-linux

❌ 2 packages failed to build:
  • gaphor
  • gaphor.dist

@nbraud
Copy link
Contributor

nbraud commented Feb 7, 2025

@getchoo, did you test this?

Executing pythonRuntimeDepsCheck
Checking runtime dependencies for gaphor-3.0.0-py3-none-any.whl

  • gaphas<5.0,>=4.0 not satisfied by version 5.0.0

@dawnchan030920
Copy link

@getchoo, did you test this?

Executing pythonRuntimeDepsCheck
Checking runtime dependencies for gaphor-3.0.0-py3-none-any.whl

  • gaphas<5.0,>=4.0 not satisfied by version 5.0.0

I'm encountering this problem on rev 9e4d5190a9482a1fb9d18adf0bdb83c6e506eaab when building gaphor-2.27.0

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 9, 2025
@getchoo getchoo marked this pull request as draft February 11, 2025 07:17
@getchoo
Copy link
Member Author

getchoo commented Feb 11, 2025

Guessing this is something introduced recently then, as OfBorg didn't come across it either. Draft until we figure it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud approved these changes

@dawidd6 dawidd6 Awaiting requested review from dawidd6

@michaelgrahamevans michaelgrahamevans Awaiting requested review from michaelgrahamevans

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@getchoo @nbraud @dawnchan030920 @wegank