rustPlatform.fetchCargoVendor: split script into two parts #377817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A POC for a possible way to split
fetchCargoVendor
's util script into two different util scirpts.This way, changing the FOD util script will not cause it to rebuild the non-FOD part, thus avoiding mass rebuilds.
Currently there's one pending change to the FOD part: #377632
Another would be to support overriding the fetching url to fetch from a different mirror. This should be easy, but I haven't implemented it yet. (#377558)
Note: by "the FOD changing" I mean its implementation, not the result (and thus, the hash).
One thing to note is that optimally, the FOD part shouldn't really change a lot. And if we change the non-FOD part, only the non-FOD stuff will get rebuilt (since FODs don't rebuild unless their name changes).
So the question is: is it even worth separating this out into multiple files.
If yes, what's a better way of doing it?
I'll keep this PR as a draft until we decide what's the best way to split it up.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.