Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustPlatform.fetchCargoVendor: split script into two parts #377817

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomaSajt
Copy link
Contributor

A POC for a possible way to split fetchCargoVendor's util script into two different util scirpts.

This way, changing the FOD util script will not cause it to rebuild the non-FOD part, thus avoiding mass rebuilds.

Currently there's one pending change to the FOD part: #377632
Another would be to support overriding the fetching url to fetch from a different mirror. This should be easy, but I haven't implemented it yet. (#377558)

Note: by "the FOD changing" I mean its implementation, not the result (and thus, the hash).

One thing to note is that optimally, the FOD part shouldn't really change a lot. And if we change the non-FOD part, only the non-FOD stuff will get rebuilt (since FODs don't rebuild unless their name changes).

So the question is: is it even worth separating this out into multiple files.
If yes, what's a better way of doing it?

I'll keep this PR as a draft until we decide what's the best way to split it up.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants