llvmPackages.tblgen: fix build on darwin #377225
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
6.topic: llvm/clang
nix-owners
bot
requested review from
Ericson2314,
dtzWill,
rrbutani,
lovek323,
alyssais,
sternenseemann and
RossComputerGuy
| # These flags are needed only for evaluating the CMake file. | ||
| ++ lib.optionals stdenv.hostPlatform.isDarwin [ | ||
| "-DLLDB_INCLUDE_TESTS=OFF" | ||
| "-DLIBXML2_INCLUDE_DIR=/non-existent" |
There was a problem hiding this comment.
Why have you added this? I've been able to build stdenv on darwin without it, actually.
There was a problem hiding this comment.
Are you sure? @emilazy commented it is not working on Darwin
There was a problem hiding this comment.
I meant LIBXML2_INCLUDE_DIR, specifically. LLDB_INCLUDE_TESTS=OFF was enough in my testing.
There was a problem hiding this comment.
Without LIBXML2_INCLUDE_DIR it is not possible to build:
error: builder for '/nix/store/vi7vr3akzqyjwdrgrkaynhmm2c80miql-llvm-tblgen-19.1.6.drv' failed with exit code 1;
last 25 log lines:
>
> CMake Error in /tmp/nix-build-llvm-tblgen-19.1.6.drv-0/llvm-tblgen-src-19.1.6/lldb/tools/lldb-server/CMakeLists.txt:
> Found relative path while evaluating include directories of "lldb-server":
>
> "LIBXML2_INCLUDE_DIR-NOTFOUND"
>
>
>
> CMake Error in /tmp/nix-build-llvm-tblgen-19.1.6.drv-0/llvm-tblgen-src-19.1.6/lldb/tools/lldb-server/CMakeLists.txt:
> Found relative path while evaluating include directories of "lldb-server":
>
> "LIBXML2_INCLUDE_DIR-NOTFOUND"
>
>
>
> -- Generating done (4.5s)
> CMake Warning:
> Manually-specified variables were not used by the project:
>
> BUILD_TESTING
> CMAKE_EXPORT_NO_PACKAGE_REGISTRY
> CMAKE_POLICY_DEFAULT_CMP0025
>
>
> CMake Generate step failed. Build files cannot be regenerated correctly.
For full logs, run 'nix log /nix/store/vi7vr3akzqyjwdrgrkaynhmm2c80miql-llvm-tblgen-19.1.6.drv'.
There was a problem hiding this comment.
aarch64-darwin (apple m4 pro)
tested on x86_64-darwin, same behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My last PR, #375654 , fails to build correctly on Darwin, as noted in this comment.
In previous PR I only tested the build on Linux (x86_64 and aarch64). It seems additional adjustments are needed for proper compatibility on Darwin.
Right now it builds successful on aarch64-darwin
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.