Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f2fs-tools: backport upstream C23 fix #377149

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Jan 26, 2025

Without the change the build against c23 compiler (like gcc-15) fails as:

f2fs-tools> In file included from libf2fs_zoned.c:10:
f2fs-tools> ../include/f2fs_fs.h:107:25: error: two or more data types in declaration specifiers
f2fs-tools>   107 | typedef u8              bool;
f2fs-tools>       |                         ^~~~

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change the build against c23 compiler (like `gcc-15`) fails as:

    f2fs-tools> In file included from libf2fs_zoned.c:10:
    f2fs-tools> ../include/f2fs_fs.h:107:25: error: two or more data types in declaration specifiers
    f2fs-tools>   107 | typedef u8              bool;
    f2fs-tools>       |                         ^~~~
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 labels Jan 26, 2025
@nix-owners nix-owners bot requested review from ehmry and jagajaga January 26, 2025 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant