hauk: init at 1.6.2 #377050
Open
hauk: init at 1.6.2 #377050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recommendations: diff --git a/pkgs/by-name/ha/hauk/package.nix b/pkgs/by-name/ha/hauk/package.nix
index 3d1edeb9bdf9..61a305586a0c 100644
--- a/pkgs/by-name/ha/hauk/package.nix
+++ b/pkgs/by-name/ha/hauk/package.nix
@@ -1,29 +1,37 @@
{
lib,
- stdenv,
+ stdenvNoCC,
fetchFromGitHub,
}:
-stdenv.mkDerivation rec {
+stdenvNoCC.mkDerivation (finalAttrs: {
pname = "hauk";
version = "1.6.2";
src = fetchFromGitHub {
owner = "bilde2910";
repo = "Hauk";
- rev = "v1.6.2";
+ tag = "v${finalAttrs.version}";
hash = "sha256-h5OXAFkaQ1nmeF6AjFQ81JCD8mZCIZAPz0JEK9cwghI=";
};
+ dontConfigure = true;
+ dontBuild = true;
+
installPhase = ''
+ runHook preInstall
+
mkdir -p $out/
cp -R ./backend-php/* $out/
cp -R ./frontend/* $out/
+
+ runHook postInstall
'';
meta = {
- license = lib.licenses.asl20;
- maintainers = with lib.maintainers; [ hlad ];
description = "Hauk is a fully open source, self-hosted location sharing service.";
homepage = "https://github.com/bilde2910/Hauk";
+ license = lib.licenses.asl20;
+ maintainers = with lib.maintainers; [ hlad ];
+ platforms = lib.platforms.unix;
};
-}
+}) |
Tert0
reviewed
Jan 30, 2025
pkgs/by-name/ha/hauk/package.nix
Outdated
| ''; | ||
|
|
||
| meta = { | ||
| description = "Hauk is a fully open source, self-hosted location sharing service."; |
There was a problem hiding this comment.
Suggested change
| description = "Hauk is a fully open source, self-hosted location sharing service."; | |
| description = "Hauk is a fully open source, self-hosted location sharing service"; |
See https://nixos.org/manual/nixpkgs/stable/#var-meta-description
Tert0
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 377050
x86_64-linux
✅ 1 package built:
- hauk
wegank
added
the
12.approvals: 1
ethancedwards8
approved these changes
Feb 1, 2025
|
wegank
added
12.approvals: 2
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/2235 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/bilde2910/Hauk
Solves #335425