-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onyx: init at 20240928 #376871
base: master
Are you sure you want to change the base?
onyx: init at 20240928 #376871
Conversation
ee29618
to
f6bf541
Compare
Is this a backport?
|
Rebased. |
…this is frustrating. all i did was rebase to master and push. no idea why there are merge conflicts when this is only an addition |
I don't see any merge conflicts. |
meta = with lib; { | ||
description = "Convert songs between Clone Hero, Rock Band, and Guitar Hero"; | ||
homepage = "https://github.com/mtolly/onyx"; | ||
license = licenses.gpl3Only; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README says:
The Onyx software is free software via the GNU GPL v3.
My transcriptions (not the compositions) are freely licensed under Creative Commons Attribution-ShareAlike. All compositions are the property of the original artists.
In addition to my own charts, this repository contains work by several other authors, including: Harmonix, Grinnz, mazegeek999, TheLieInKing, and more. (Credited in individual song READMEs.) Other authors' work hosted here is not necessarily licensed in the same way; please contact them if you want permission to redistribute or repackage charts.
Just do double check: We only distribute the software and none of the other stuff mentioned here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shit.
I presumed the appimage was just the binary, but you inspired me to go spelunking through the /nix/store to be sure, and I found songs are being packaged in there.
I'll open an issue on that repo.
Co-authored-by: Wolfgang Walther <[email protected]>
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.