opencv: switch to openexr_3 #375774
Open
opencv: switch to openexr_3 #375774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 tasks
|
|
This is ready for review, although I need to check the issue with all these python 3.13 packages. |
|
I do have failed tests though: |
|
Ok those tests also fails on master. |
|
@basvandijk this is ready now. Please review :-) |
autra
commented
Jan 26, 2025
| @@ -28,8 +28,7 @@ | |||
| , enableWebP ? true | |||
| , libwebp | |||
| , enableEXR ? !stdenv.hostPlatform.isDarwin | |||
| , openexr | |||
| , ilmbase | |||
| , openexr_3 | |||
There was a problem hiding this comment.
note: this is going to be switched back to openexr in #367406
SuperSandro2000
added
the
1.severity: security
SuperSandro2000
approved these changes
Feb 4, 2025
autra
force-pushed
the
opencv_switch_to_openexr_3
branch
from
b116fce to
fe7bf1b
Compare
|
Rebased onto latest master. |
|
@SuperSandro2000 thanks for the approve! Do you think this could be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Follow up of #367406 : opencv v2 is EOL and has security vulnerabilities.
This switches the build of opencv to openexr v3.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.