kotatsu-dl: init at v 0.5 #375562
kotatsu-dl: init at v 0.5 #375562
Conversation
NixOSInfra
added
the
12. first-time contribution
Changes the hash to the right one
| src = pkgs.fetchurl { | ||
| url = "https://github.com/KotatsuApp/kotatsu-dl/releases/download/v${version}/kotatsu-dl.jar"; | ||
| sha256 = "sha256-GI/PLt8wbVs2R78PbQg/9/Rea33j6CFQjuqhYIQGimM="; | ||
| }; |
There was a problem hiding this comment.
It would be better to build from source and use fetchFromGithub as the fetcher.
| # Skip the unpackPhase since it's just a JAR file, not an archive | ||
| phases = [ "installPhase" ]; |
There was a problem hiding this comment.
When building from source with the correct fetcher, this will not be needed.
| buildInputs = [ pkgs.openjdk ]; | ||
| propagatedBuildInputs = [ pkgs.openjdk ]; | ||
|
|
||
| installPhase = '' |
There was a problem hiding this comment.
Start and end every manually-defined main phase with runHook pre<phaseName> and runHook post<phaseName>.
So here it would be
installPhase = ''
runHook preInstall
# Installing...
runHook postInstall
''| meta = with pkgs.lib; { | ||
| description = "Easy-to-use cli manga downloader with a 1k+ sources supported"; | ||
| license = licenses.gpl3; | ||
| }; |
There was a problem hiding this comment.
Expand the meta attrset with additional information. We also need a maintainer. Would you be willing to maintain the package yourself?
For the additional meta attributes, see the manual for meta attributes such as homepage, maintainers, platforms, longdescription, etc.
For meta.changelog, use
changelog = "https://github.com/KotatsuApp/kotatsu-dl/releases/tag/v${version}";|
|
||
| meta = with pkgs.lib; { | ||
| description = "Easy-to-use cli manga downloader with a 1k+ sources supported"; | ||
| license = licenses.gpl3; |
There was a problem hiding this comment.
| license = licenses.gpl3; | |
| license = licenses.gpl3Only; |
Since the licence does not allow using higher versions of GPLv3.
| @@ -0,0 +1,41 @@ | |||
| { pkgs }: | |||
There was a problem hiding this comment.
Never use pkgs in the top-level package inputs. Always directly import all that you need. So stdenv, fetchFromGithub, ... It allows for easier overrides of
the package.
Adda0
added
8.has: package (new)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.