Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a-keys-path: init at 0.7.1 #373994

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

a-keys-path: init at 0.7.1 #373994

wants to merge 1 commit into from

Conversation

phanirithvij
Copy link
Member

@phanirithvij phanirithvij commented Jan 15, 2025 •
edited
Loading

A Key(s) Path is a winner of the GMTK Game Jam 2020.

https://geegaz.itch.io/out-of-controls
https://github.com/geegaz/A-Key-s-Path

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 15, 2025
@phanirithvij phanirithvij added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Jan 15, 2025
nbraud
nbraud reviewed Jan 24, 2025
View reviewed changes
pkgs/by-name/a-/a-keys-path/package.nix Outdated
desktopItems = [
(makeDesktopItem {
name = "a-keys-path";
exec = "a-keys-path";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use the full path?

Copy link
Member Author

@phanirithvij phanirithvij Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not many applications are doing it, but I added it

Copy link
Member Author

@phanirithvij phanirithvij Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after doing a nixos-rebuild switch, does the desktop environment reload these?

if not, this new change will break the desktop entry

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nbraud could you re-review?

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373994

Tert0
Tert0 reviewed Feb 1, 2025
View reviewed changes
pkgs/by-name/a-/a-keys-path/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/a-/a-keys-path/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 2, 2025
@Tert0
Copy link
Member

Tert0 commented Feb 3, 2025

LGTM.
Please squash the commits into one commit.

@phanirithvij
a-keys-path: init at 0.7.1
0c310f5 
Signed-off-by: phanirithvij <[email protected]>
@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373994

@phanirithvij phanirithvij added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 4, 2025
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 4, 2025
@ethancedwards8 ethancedwards8 added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Feb 6, 2025
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person and removed 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people labels Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbraud nbraud nbraud left review comments

@Tert0 Tert0 Tert0 left review comments

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phanirithvij @ethancedwards8 @Tert0 @nbraud @wegank