Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frr: add optional grpc support via grpcSupport parameter #373865

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tylerjl
Copy link
Contributor

@tylerjl tylerjl commented Jan 14, 2025

I've been running FRR with gRPC support for a while now with these changes to the upstream package in an overlay. Thought it'd be worth upstreaming. Notes:

  • I'm not thrilled about adding CXXFLAGS to the derivation since it changes the package regardless of whether or not you enable gRPC, but it seems to behave fine. And if upstream isn't setting something like -std explicitly, it makes me think that adding it to the downstream nix package will probably just make it behave a little more like upstream intends.
  • The parameter is set to true by default, but I'm happy to set this to false if pulling in grpc and protobuf is a little much.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 14, 2025
@nix-owners nix-owners bot requested review from woffs and thillux January 14, 2025 22:00
Copy link
Contributor

@thillux thillux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Jan 16, 2025
] ++ lib.optionals grpcSupport [
grpc
protobuf
which
Copy link
Member

@fpletz fpletz Feb 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is which really a runtime dependency? If it's only used at buildtime, this should go into nativeBuildInputs.

@fpletz fpletz added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants