frr: add optional grpc support via grpcSupport parameter #373865
+14
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been running FRR with gRPC support for a while now with these changes to the upstream package in an overlay. Thought it'd be worth upstreaming. Notes:
CXXFLAGS
to the derivation since it changes the package regardless of whether or not you enable gRPC, but it seems to behave fine. And if upstream isn't setting something like-std
explicitly, it makes me think that adding it to the downstream nix package will probably just make it behave a little more like upstream intends.true
by default, but I'm happy to set this tofalse
if pulling ingrpc
andprotobuf
is a little much.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.