treewide: remove "with lib;" from meta #373573
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a lot of packages treewide to remove the
with lib;
pattern frommeta
.This removes one
with
scope. Furthermore, in many PRs that add a package there is a review that asks for adding or removingwith lib;
from themeta
expression (I encountered both requests). It would be more efficient if there was one way to writemeta
on which we can all agree. There is https://nix.dev/guides/best-practices.html#with-scopes stating thatwith
scopes should not be used for large scopes.meta
could be considered a small scope, though.There is also the opposite done in #373548. Of course, it only makes sense to merge either this PR or the other one. I can live with either choice, but the codebase should reflect that choice (which is what this PR aims for), and it should be documented.
For now, I only consider
.nix
files that are already formatted withnixfmt
.Things done
meta
attr they touch unchanged.nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.