Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: remove "with lib;" from meta #373573

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zeuner
Copy link
Contributor

@zeuner zeuner commented Jan 13, 2025

This PR changes a lot of packages treewide to remove the with lib; pattern from meta.

This removes one with scope. Furthermore, in many PRs that add a package there is a review that asks for adding or removing with lib; from the meta expression (I encountered both requests). It would be more efficient if there was one way to write meta on which we can all agree. There is https://nix.dev/guides/best-practices.html#with-scopes stating that with scopes should not be used for large scopes. meta could be considered a small scope, though.

There is also the opposite done in #373548. Of course, it only makes sense to merge either this PR or the other one. I can live with either choice, but the codebase should reflect that choice (which is what this PR aims for), and it should be documented.

For now, I only consider .nix files that are already formatted with nixfmt.

Things done

  • Verified all patches leave the value of the meta attr they touch unchanged.
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 13, 2025
@github-actions github-actions bot added 6.topic: qt/kde 6.topic: vim 6.topic: docker tools 6.topic: vscode 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Jan 13, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 14, 2025
@github-actions github-actions bot added the 6.topic: cinnamon Desktop environment label Jan 14, 2025
@zeuner zeuner force-pushed the meta-with-remove branch 3 times, most recently from d0637ed to 2a75f93 Compare January 15, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cinnamon Desktop environment 6.topic: docker tools 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: qt/kde 6.topic: vim 6.topic: vscode 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant