treewide: directly pass cargoRoot to fetcher #373541
Draft
+62
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: python
8.has: documentation
nix-owners
bot
requested review from
winterqt,
figsoda,
zowoq,
ttuegel,
K900,
SuperSandro2000 and
NickCao
|
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #356811
this is just part 1, should be only the low rebuild count packages
things that should be in part 2:
rubyQuestion: should the docs follow the formatting rules, or can it stay in a format that's more readable (single-line)?
Note: for packages that didn't do
name="${pname}-${version}";orinherit pname versionalready, the output name of the FOD will change, thus the FOD hash will also change.Note: I have split this PR into separate commits in case some parts need backporting. (probably the hash changes) (but maybe everything can be backported)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.