-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pshash: init at 0.1.11.0 #371852
base: master
Are you sure you want to change the base?
pshash: init at 0.1.11.0 #371852
Conversation
Welcome to nixpkgs! To make things easier for reviewers, please avoid changing the checklist and make sure that your pull request adheres to CONTRIBUTING.md. |
Thank you for maintaining this wonderful project! I apologize for my ill-written pull request, all checks run successfully now, and I reverted the checklist to default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks better now but there should be two commits. See #361576 (comment) for a similar Haskell PR that was accepted recently
Thank you for your detailed feedback! I made changes accordingly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would suggest to run the tests: diff --git a/pkgs/by-name/ps/pshash/package.nix b/pkgs/by-name/ps/pshash/package.nix
index a708709141f7..d73b7774929b 100644
--- a/pkgs/by-name/ps/pshash/package.nix
+++ b/pkgs/by-name/ps/pshash/package.nix
@@ -13,9 +13,15 @@ haskellPackages.mkDerivation rec {
hash = "sha256-2lb8WxZb9e3hTnBiXAbyOer9EqbBEsnOAbJfPPdvIGc=";
};
+ postPatch = ''
+ patchShebangs --build test/output.sh
+ substituteInPlace test/output.sh \
+ --replace-fail 'compare "$cmd -f /' "# "
+ '';
+
isLibrary = false;
isExecutable = true;
- doCheck = false;
+ doCheck = true;
executableHaskellDepends = with haskellPackages; [
base
@@ -23,6 +29,12 @@ haskellPackages.mkDerivation rec {
directory
];
+ checkPhase = ''
+ runHook preCheck
+ test/output.sh dist/build/pshash/pshash
+ runHook postCheck
+ '';
+
license = lib.licenses.mit;
description = "Functional pseudo-hash password creation tool";
homepage = "https://github.com/thornoar/pshash"; |
Summary
Adding a simple password generation tool called
pshash
, designed to create very secure passwords using a pseudo-hashing function and a set of public and private keys, without storing the resulting passwords anywhere. E.g. runningpshash google 123 456
(with private keys 123 and 456) will yieldVLCJXY4y*tm&Z3Db$5a0h#?jo
, which can then be used as one's password to Google. See more at https://github.com/thornoar/pshash#synopsis and even more in the accompanying paper proposal at https://github.com/thornoar/pshash/blob/master/documentation/main.pdf.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.