gam: 6.58 -> 7.03.04 #369799
Open
gam: 6.58 -> 7.03.04 #369799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thanegill
force-pushed
the
gam7
branch
2 times, most recently
from
2fde1fc to
1c38080
Compare
wegank
added
the
2.status: merge conflict
thanegill
force-pushed
the
gam7
branch
2 times, most recently
from
bb31032 to
b2a421d
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5075 |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5179 |
antonmosich
reviewed
Feb 6, 2025
Re-formatted. |
antonmosich
approved these changes
Feb 8, 2025
There was a problem hiding this comment.
Code LGTM now, and binary executes on my machine
Edit: you have a merge conflict that seems to be happening due to 0cd04d3, which changed the rev to tag already, rebasing on master and resolving the conflict should make the PR mergable.
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355980
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.