-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpu-screen-recorder-ui: init at 1.1.7 #369574
base: master
Are you sure you want to change the base?
Conversation
pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-notification.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-ui.nix
Outdated
Show resolved
Hide resolved
Please introduce the packages in pkgs/by-name instead EDIT: it will be easier to maintain because of bots |
I want to move |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Here are my overall observations:
- I think the ui module should be consolidated into the existing
gpu-screen-recorder
module instead of being a separate one. For instanceprograms.gpu-screen-recorder.ui.enable = true;
The service should be started by default with theui.enable
option set to true, but allow to be disabled.Maybe allow for the notification to be disabled. Not sure why people would do that, but you never know.- Agreed that the package should be moved to
by-name
.
|
pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-notification.nix
Outdated
Show resolved
Hide resolved
pkgs/applications/video/gpu-screen-recorder/gpu-screen-recorder-ui.nix
Outdated
Show resolved
Hide resolved
I don't see a any dependency on that. You must init this in by-name by the way; it's policy now. |
83c78fe
to
09a7171
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 369574
x86_64-linux
✅ 2 packages built:
- gpu-screen-recorder-notification
- gpu-screen-recorder-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
09a7171
to
d03a644
Compare
https://git.dec05eba.com/gpu-screen-recorder-ui/about/
Fullscreen overlay UI for GPU Screen Recorder in the style of ShadowPlay
Closes #369558
Depends on #367552
Usage
gsr-ui
systemctl enable --now --user gpu-screen-recorder-ui
Question: Should this be a nixos module option?
Alt+Z
(key binds are not configurable yet)Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.