Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bitwarden-desktop: add darwin support and do minor refactor #369559

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TomaSajt
Copy link
Contributor

@TomaSajt TomaSajt commented Dec 31, 2024

cc: @amarshall

Alternative to #303417
Alternative to #368638

This PR adds darwin support to bitwarden-desktop.

The new platform-triple patch reduces the complexity of the derivation by not having to do renaming in postBuild, which would have got more complicated if we had to handle darwin too.

In the install phase I used ${lib.optionalString ...} to do conditional stuff. If you prefer to use ++ lib.optionalString ... ++ I can swap it out.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@amarshall
Copy link
Member

At first glance, this looks pretty good—thanks! Will get to full review and testing soon-ish.

@damidoug
Copy link
Contributor

Im using this version on darwin, its working cool.

I just recommend add the updater to allow we update bitwarden from the app.

@amarshall
Copy link
Member

Installing via Nix is fundamentally incompatible with in-app updates, as either the app will try and fail to update because the store is read-only, or try and succeed and corrupt the store. If it does succeed, a future apply of the NixOS (or nix-darwin or home-manager) config may also rollback the update. TL;DR: if you want in-app updates outside of Nix, do not install via Nix.


I should hopefully be able to look at this some more this weekend.

@TomaSajt
Copy link
Contributor Author

TomaSajt commented Jan 11, 2025

Added a patch which makes the app just open the releases page when an update is available.
This is done by forcing a canUpdate to false.

If it's better, I can make it just do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants