sparkleshare: Remove #369454
Open
sparkleshare: Remove #369454
+2
−103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The project has been unmaintained for a while now and has started failing to build. Abandonment notice from the maintainer: hbons/SparkleShare#2006 It has been a good run but it is time to say goodbye. Thanks to hbons for all of the work over the years. It looks like there is a good chance of a fork living on but it will take time to see how that shakes out. So for now let's just remove the package.
github-actions
bot
added
6.topic: nixos
|
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Not sure why I was requested for review? |
|
I'm not sure either. You were recommended by GitHub and I didn't check closely. Feel free to ignore if you wish. |
|
@kevincox Reviews happen over time. Wait a week; if nobody reviews/merges, then ask in either Discourse or Matrix in the review request areas. GitHub sets you up for failure with those reviewer recommendations, since most of the time they aren't relevant to the package. |
|
@ofborg build owncloud-client The following builds need to succeed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project has been unmaintained for a while now and has started failing to build.
Abandonment notice from the maintainer: hbons/SparkleShare#2006
It has been a good run but it is time to say goodbye. Thanks to hbons for all of the work over the years. It looks like there is a good chance of a fork living on but it will take time to see how that shakes out. So for now let's just remove the package.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.