treewide/nixos: remove with lib; part 11
#369234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-11
branch
from
6d90711 to
d9a74a3
Compare
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-11
branch
from
d9a74a3 to
6c14bd4
Compare
Stunkymonkey
force-pushed
the
treewide-nixos-remove-with-lib-11
branch
from
6c14bd4 to
8b69ba0
Compare
Stunkymonkey
commented
Dec 29, 2024
| @@ -60,7 +57,7 @@ let | |||
| exit $_status | |||
| ''; | |||
|
|
|||
| path = with pkgs; map getBin | |||
| path = with pkgs; map lib.getBin | |||
There was a problem hiding this comment.
somehow I had to do this manually...
There was a problem hiding this comment.
Yeah, I think your script has an error when there's an inner with.
github-actions
bot
added
10.rebuild-darwin: 0
|
Based on my experience merging the other PRs, Felix (@Stunkymonkey), I'm going to sit it out for a while. I don't have enough confidence there are zero defects here, and I know with the new script, I'd need to actually run tests against all the modules here -- which I don't have the computing power to do, and I don't think you do either. |
wegank
added
the
2.status: merge conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #208242
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.