-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add data dir config for meilisearch #369216
base: master
Are you sure you want to change the base?
Conversation
I have (so far) not added any tests. Will that be necessary for this change? Also, the creation of the |
This PR fails according to formatting. I'm using Alejandra. Apparently, that's not good enough. How should I format the code? |
There is a nixpkgs specific formatter, its a package. It should be in the contrib docs. I would link to it but im on mobile. |
True, it would be simpler. However, it would mean that we use "something custom built" in all cases and no longer leverage the systemd's |
We could have statedirectory be an mkif with the condition that datadir = /var/lib/meilisearch for example Statedirectory handle the creation of a directory with special permissions , thats it as far as i know. But yes, better to keep it. |
@@ -64,6 +58,15 @@ in | |||
type = with types; nullOr path; | |||
}; | |||
|
|||
datadir = mkOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it should be dataDir
by convention.
Extend the config of the meilisearch module to allow setting a custom location for meilisearch to store its data. This is non-trivial due to the dynamic user that's used here. Fixes #368611
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.