Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargoCheckHook: proof of concept of fix for the test-threads issue #368593

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Dec 27, 2024

Some tests are failing because an extra arg is being passed to set the amount of threads for cargo test.

This is a proof of concept with the assumption that the arguments passed somehow are stepping on toes of
other argument parsers. Assuming that this amount of threads can also be passed via RUST_TEST_THREADS,
we could achieve the same behaviour and avoid causing this problem.

  • cargoCheckHook: pass test-threads using an environment variable
  • treewide: reenable tests of packages affected with the test-threads issue

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew lucasew mentioned this pull request Dec 27, 2024
13 tasks
@lucasew
Copy link
Contributor Author

lucasew commented Dec 27, 2024

I plan to first test with the affected packages, and if I get success with them I rebase this PR to staging because of the amount of rebuilds. That way I do not have to run reviewd in rounds because of the amount of packages.

@lucasew
Copy link
Contributor Author

lucasew commented Dec 28, 2024

The PoC works, but there are failing tests not related to the issue being fixed in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant