-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fluent-bit: link against Nix dependencies, fix Darwin builds, and add NixOS module #365493
Open
commiterate
wants to merge
1
commit into
NixOS:master
Choose a base branch
from
commiterate:init/fluent-bit-module
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f956bdc
to
d699387
Compare
commiterate
commented
Dec 16, 2024
d699387
to
3a9ac5a
Compare
1a806f0
to
a77fc83
Compare
a77fc83
to
29466a6
Compare
fpletz
reviewed
Dec 19, 2024
29466a6
to
4f85137
Compare
4f85137
to
95cfa06
Compare
commiterate
commented
Dec 20, 2024
Scrumplex
reviewed
Jan 1, 2025
43fd7da
to
4f31d27
Compare
a178dea
to
5853cde
Compare
5853cde
to
3367011
Compare
arianvp
reviewed
Feb 4, 2025
arianvp
reviewed
Feb 4, 2025
b08c5d4
to
87143f3
Compare
I'm gonna give this a test run today and if all good I'm happy to add myself as the maintainer of this. |
87143f3
to
547792d
Compare
547792d
to
2ee5637
Compare
2ee5637
to
3fccd0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: darwin
Running or building packages on Darwin
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: changelog
8.has: documentation
This PR adds or changes documentation
8.has: module (new)
This PR adds a module in `nixos/`
8.has: tests
This PR has tests
10.rebuild-darwin: 1
10.rebuild-linux: 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link against Nix dependencies, fix Darwin builds, and add NixOS module (upstreams commiterate/nix-fluent-bit).
fluent-bit vends its dependencies by keeping a copy of their sources under
lib/
in their source tree and building them from source. All of the dependencies their CMake setup can source from the system are already Nix packages (e.g.libbacktrace
,luajit
).Darwin builds have also been silently broken for awhile now.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.