-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hpack: 0.36.1 -> 0.37.0 #364979
base: master
Are you sure you want to change the base?
hpack: 0.36.1 -> 0.37.0 #364979
Conversation
The latest version of Haskell's `hpack` is 0.37.0. Increasingly `.cabal` files begin with a comment that causes Nixpkgs' `hpack` to reject them entirely: ``` -- This file has been generated from package.yaml by hpack version 0.37.0. -- -- see: https://github.com/sol/hpack ``` ``` $ hpack shellwords.cabal was generated with a newer version of hpack, please upgrade and try again. ``` Unfortunately, `hpack`'s `--force` option does not override this error; you need to remove the `.cabal` file in question manually, which can be annoying in repositories with many `package.yaml` files. Using the latest version of `hpack`, which is provided by Nixpkgs but not set as the default for unclear reasons. `hpack ==0.36.1` is listed as a constraint in `pkgs/development/configuration-hackage2nix/stackage.yaml`, but `pkgs/development/haskell-modules/configuration-common.nix` makes sure to set `hpack = self.hpack_0_37_0` for Stack itself. See: pkgs/test/haskell/upstreamStackHpackVersion/default.nix
then | ||
haskellPackages.hpack_0_37_0 | ||
else | ||
lib.warn "`hpack` is newer than `hpack_0_37_0`. Please remove the override in Nixpkgs: ${builtins.toPath ./package.nix}" haskellPackages.hpack; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a warning here in case hpack
gets updated past 0.37.0
without us noticing.
@sternenseemann Do you know why |
We inherit the hpack version from Stackage which restricts hpack to a specific version range that doesn't cause brakage according to PVP. nixpkgs/maintainers/scripts/haskell/update-stackage.sh Lines 58 to 74 in 3566ab7
|
@sternenseemann Thanks! It looks like |
The latest version of Haskell's
hpack
is 0.37.0. Increasingly.cabal
files begin with a comment that causes Nixpkgs'hpack
to reject them entirely:Unfortunately,
hpack
's--force
option does not override this error; you need to remove the.cabal
file in question manually, which can be annoying in repositories with manypackage.yaml
files.Using the latest version of
hpack
, which is provided by Nixpkgs but not set as the default for unclear reasons.hpack ==0.36.1
is listed as a constraint inpkgs/development/configuration-hackage2nix/stackage.yaml
, butpkgs/development/haskell-modules/configuration-common.nix
makes sure to sethpack = self.hpack_0_37_0
for Stack itself.See: pkgs/test/haskell/upstreamStackHpackVersion/default.nix
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.