postfixadmin: 3.3.13 -> 3.3.15 #362517
Open
postfixadmin: 3.3.13 -> 3.3.15 #362517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kamillaova
force-pushed
the
update/postfixadmin
branch
3 times, most recently
from
f169f2f to
9efe95e
Compare
github-actions
bot
added
10.rebuild-darwin: 0
Kamillaova
force-pushed
the
update/postfixadmin
branch
3 times, most recently
from
19d3120 to
8b3a797
Compare
|
@ofborg build nixosTests.postfixadmin |
Kamillaova
commented
Dec 6, 2024
wegank
added
the
2.status: merge conflict
Kamillaova
force-pushed
the
update/postfixadmin
branch
from
f398240 to
c18bea5
Compare
Kamillaova
removed
the
2.status: merge conflict
| }) | ||
| ]; | ||
|
|
||
| strictDeps = true; |
There was a problem hiding this comment.
there are no buildInputs here, so strictDeps is pretty useless
| configLocalPath ? "/etc/postfixadmin/config.local.php", | ||
| templatesCachePath ? "/var/cache/postfixadmin/templates_c", |
There was a problem hiding this comment.
Why do we need those options? they are unused currently in the module and I doubt that we really need them.
There was a problem hiding this comment.
Someone might want to change those paths, I don't think it's really unnecessary here
There was a problem hiding this comment.
I think they should be added once somebody really needs them and not just because they might potentially not be unused.
Kamillaova
force-pushed
the
update/postfixadmin
branch
from
c18bea5 to
771e05d
Compare
ofborg
bot
added
the
2.status: merge conflict
Kamillaova
force-pushed
the
update/postfixadmin
branch
from
771e05d to
59bb614
Compare
ofborg
bot
removed
the
2.status: merge conflict
Kamillaova
force-pushed
the
update/postfixadmin
branch
from
59bb614 to
79ce659
Compare
Because the package uses `/etc` and `/var/cache`
Kamillaova
force-pushed
the
update/postfixadmin
branch
from
79ce659 to
6220337
Compare
|
ready to review |
Kamillaova
changed the title
Comment on lines
27
to
33
| meta = with lib; { | ||
| description = "Web based virtual user administration interface for Postfix mail servers"; | ||
| homepage = "https://postfixadmin.sourceforge.io/"; | ||
| maintainers = with lib.maintainers; [ globin ]; | ||
| license = lib.licenses.gpl2Plus; | ||
| platforms = lib.platforms.all; | ||
| maintainers = with maintainers; [ globin ]; | ||
| license = licenses.gpl2Plus; | ||
| platforms = platforms.all; | ||
| }; |
There was a problem hiding this comment.
I think consensus is to go the other way and not use with lib, see #208242.
| configLocalPath ? "/etc/postfixadmin/config.local.php", | ||
| templatesCachePath ? "/var/cache/postfixadmin/templates_c", |
There was a problem hiding this comment.
I think they should be added once somebody really needs them and not just because they might potentially not be unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.