-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ant: rip out ant-contrib #359137
Draft
tomodachi94
wants to merge
1
commit into
NixOS:staging
Choose a base branch
from
tomodachi94:enhance/ant/remove-ant-contrib
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ant: rip out ant-contrib #359137
tomodachi94
wants to merge
1
commit into
NixOS:staging
from
tomodachi94:enhance/ant/remove-ant-contrib
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb9cb09
to
d8ac21b
Compare
0ffd08a
to
6d05fc9
Compare
I need to check broken packages to make sure this removal without a replacement doesn't compound the failures. |
13 tasks
This comment was marked as outdated.
This comment was marked as outdated.
13 tasks
6d05fc9
to
e45e73a
Compare
e45e73a
to
674ef95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: merge conflict
This PR has merge conflicts with the target branch
6.topic: java
Including JDK, tooling, other languages, other VMs
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
8.has: changelog
8.has: clean-up
8.has: documentation
This PR adds or changes documentation
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nixpkgs-review reveals no new failures when we remove this, so let's rip it out per the rationale at #357758.
Closes #357758.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.