Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ant: rip out ant-contrib #359137

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

tomodachi94
Copy link
Member

nixpkgs-review reveals no new failures when we remove this, so let's rip it out per the rationale at #357758.

Closes #357758.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomodachi94 tomodachi94 force-pushed the enhance/ant/remove-ant-contrib branch from cb9cb09 to d8ac21b Compare November 25, 2024 22:30
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: changelog labels Nov 25, 2024
@tomodachi94 tomodachi94 requested a review from a team November 25, 2024 22:30
@tomodachi94 tomodachi94 force-pushed the enhance/ant/remove-ant-contrib branch 2 times, most recently from 0ffd08a to 6d05fc9 Compare November 26, 2024 08:35
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 labels Nov 27, 2024
@tomodachi94 tomodachi94 marked this pull request as draft November 27, 2024 04:21
@tomodachi94
Copy link
Member Author

I need to check broken packages to make sure this removal without a replacement doesn't compound the failures.

@tomodachi94

This comment was marked as outdated.

@tomodachi94 tomodachi94 added the 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed label Nov 29, 2024
@tomodachi94 tomodachi94 added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed labels Nov 30, 2024
@tomodachi94 tomodachi94 force-pushed the enhance/ant/remove-ant-contrib branch from 6d05fc9 to e45e73a Compare November 30, 2024 00:14
@tomodachi94 tomodachi94 removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 30, 2024
@github-actions github-actions bot added the 6.topic: java Including JDK, tooling, other languages, other VMs label Nov 30, 2024
@tomodachi94 tomodachi94 force-pushed the enhance/ant/remove-ant-contrib branch from e45e73a to 674ef95 Compare December 2, 2024 19:22
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: java Including JDK, tooling, other languages, other VMs 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog 8.has: clean-up 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant