Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coreboot-utils: turn into package set #358769

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ninelore
Copy link
Contributor

@ninelore ninelore commented Nov 24, 2024

After discussing it with @felixsinger, we came to the conclusion that coreboot-utils should be a package set.

Looking for feedback on the implementation as well as how I should handle the breaking changes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ninelore ninelore marked this pull request as draft November 24, 2024 19:48
@ninelore ninelore force-pushed the coreboot-utils-set branch 3 times, most recently from ef430a2 to ae447eb Compare November 24, 2024 20:31
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 25, 2024
@Mindavi
Copy link
Contributor

Mindavi commented Nov 29, 2024

I generally have the feeling we're trying to move towards less package sets, not more. But I might not be completely up to date with the latest standards.

@danth
Copy link
Contributor

danth commented Dec 10, 2024

I generally have the feeling we're trying to move towards less package sets, not more.

This seems to be the case with the GNOME packages, at least.

@ninelore
Copy link
Contributor Author

this should be similar to what has been done to nerd-fonts

@ninelore
Copy link
Contributor Author

TODO: pkgs.coreboot-utils is no longer a derivation but a set. I wasn't able to implement a proper throw with a helpful message yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants