Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncurses: provide openbsd version number in host triple #358066

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

rhelmot
Copy link
Contributor

@rhelmot rhelmot commented Nov 22, 2024

Unversioned openbsd will trip a configure branch that assumes your openbsd is from the 90s. This leads to a truly awful compiler/linker configuration. No, autoreconfHook doesn't work.

Things done

  • Built on platform(s)
    • x86_64-linux (openbsd cross)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Unversioned openbsd will trip a configure branch that assumes your
openbsd is from the 90s. This leads to a truly awful compiler/linker
configuration. No, autoreconfHook doesn't work.
@Ericson2314
Copy link
Member

I think this commit message is better as a code-comment. One of the two items can get the comment, and the other can have a "see ... above ..." / "see ... below ...."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants