Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step-cli: fix hash #355610

Merged
merged 1 commit into from
Nov 14, 2024
Merged

step-cli: fix hash #355610

merged 1 commit into from
Nov 14, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Nov 13, 2024

Apply the same fix as in amaranth-boards

fixes https://hydra.nixos.org/build/277511307 via #352644 (comment)
zhf #352882

closes #355009

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds marked this pull request as ready for review November 13, 2024 07:47
@pbsds pbsds mentioned this pull request Nov 13, 2024
13 tasks
@K900
Copy link
Contributor

K900 commented Nov 13, 2024

This feels wrong? We're not even getting a full git checkout here, just a tarball. Have you confirmed that this is the issue?

@pbsds
Copy link
Member Author

pbsds commented Nov 13, 2024

My guess is that the master branch also pointed to the ref when the hash was set

@Mic92
Copy link
Member

Mic92 commented Nov 13, 2024

This feels wrong? We're not even getting a full git checkout here, just a tarball. Have you confirmed that this is the issue?

The github api does this with tarballs. Gitea as well. This is a known issue. Also see NixOS/nix#11467

@katexochen katexochen mentioned this pull request Nov 13, 2024
13 tasks
@pbsds pbsds force-pushed the fix-step-cli-1731483413 branch from 8729295 to 3b8c15e Compare November 13, 2024 15:56
@ofborg ofborg bot requested a review from isabelroses November 14, 2024 03:53
@Aleksanaa Aleksanaa merged commit 2da099a into NixOS:master Nov 14, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants