amazon-ec2-utils: wrap programs #355259
Merged
amazon-ec2-utils: wrap programs #355259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
from
989e575 to
18ffc24
Compare
arianvp
reviewed
Nov 12, 2024
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
from
18ffc24 to
6ffa680
Compare
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
4 times, most recently
from
b6d75b2 to
95e8065
Compare
commiterate
changed the title
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
from
95e8065 to
5e1d5e5
Compare
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
from
5e1d5e5 to
0fffa42
Compare
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
from
0fffa42 to
7b93936
Compare
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
from
7b93936 to
c22048e
Compare
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
from
c22048e to
06a71d9
Compare
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
from
06a71d9 to
672e67c
Compare
arianvp
approved these changes
Jan 6, 2025
|
Just so I understand correctly. Are the udev rules currently broken because of this? |
wegank
added
the
12.approvals: 1
|
Yup since they're trying to use programs that aren't on their |
commiterate
force-pushed
the
update/amazon-ec2-utils
branch
from
672e67c to
d87f62c
Compare
wegank
removed
the
12.approvals: 1
|
Should we backport this? |
|
If the NixOS AMIs are locked to 24.11 instead of tracking nixos-unstable and we want it there, then yes. |
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping the shell script programs to add all dependency programs to their
PATHenvironment variable.Upstream made some changes to the dependencies they're using (e.g. added a dependency on
getoptwhich is fromutil-linux).Also including some style changes to match #355111.
As a side note, upstream seems to plan on potentially replacing
ebsnvme-idwithebsnvme, but this change hasn't been released yet (onmainbut not part of a release yet).Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.