rustPlatform.maturinBuildHook: preserve existing buildPhase #349068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SomeoneSerge
force-pushed
the
fix/maturinBuildHook/presetBuildPhase
branch
from
8e17951 to
7662816
Compare
SomeoneSerge
changed the title
This is important when reusing cargoBuildHook outside buildRustPackage (e.g. in buildPythonPackage)
SomeoneSerge
force-pushed
the
fix/maturinBuildHook/presetBuildPhase
branch
from
7662816 to
3c2607a
Compare
ofborg
bot
added
10.rebuild-darwin-stdenv
FliegendeWurst
requested changes
Dec 5, 2024
There was a problem hiding this comment.
Build for python3Packages.cryptography breaks
Traceback (most recent call last):
File "/nix/store/0xhx8c69s82819wx8jw0ddbd2ad83s0s-python3.12-pyproject-hooks-1.2.0/lib/python3.12/site-packages/pyproject_hooks/_impl.py", line 402, in _call_hook
raise BackendUnavailable(
pyproject_hooks._impl.BackendUnavailable: Cannot import 'maturin'
ERROR Backend 'maturin' is not available.
error: builder for '/nix/store/5c1b7jsmmm396k92zih1bnrkl5z3cj79-python3.12-cryptography-43.0.1.drv' failed with exit code 1;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix minor annoyances related to #296544
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.