Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automake: 1.16 -> 1.17 #340373

Draft
wants to merge 2 commits into
base: staging
Choose a base branch
from
Draft

automake: 1.16 -> 1.17 #340373

wants to merge 2 commits into from

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Sep 7, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux-stdenv This PR causes stdenv to rebuild labels Sep 7, 2024
@trofi trofi marked this pull request as draft September 8, 2024 05:37
@trofi
Copy link
Contributor Author

trofi commented Sep 8, 2024

Breaks at least gnutls:

/build/gnutls-3.8.6/build-aux/missing: line 81: automake-1.16: command not found

Switching to draft.

trofi added 2 commits September 8, 2024 06:54
@trofi
gnutls: use autoreconfHook, do not rely on ./configure's reconfigure
625628c 
Without the change the build fails to run `automake-1.16` if automake is
`1.17`:

> /build/gnutls-3.8.6/build-aux/missing: line 81: automake-1.16: command not found
@trofi
automake: 1.16 -> 1.17
a6a4496
@trofi
Copy link
Contributor Author

trofi commented Sep 8, 2024

Added gnutls: use autoreconfHook, do not rely on ./configure's reconfigure to fix gnutls build failure.

@ofborg ofborg bot requested a review from vcunat September 8, 2024 08:07
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adevress adevress Awaiting requested review from adevress

@bjornfor bjornfor Awaiting requested review from bjornfor

@amiloradovsky amiloradovsky Awaiting requested review from amiloradovsky

@gebner gebner Awaiting requested review from gebner

@prusnak prusnak Awaiting requested review from prusnak

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trofi @wegank