Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson.setupHook: support setOutputFlags #340089

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Sep 6, 2024

Description of changes

This matches the behaviour of the default configurePhase. I have deliberately not copied that having only a single output means these flags are not set by default, because that's something we should be moving away from in stdenv, but an explicit opt out is still useful, for example when building in a nix-shell.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This matches the behaviour of the default configurePhase.  I have
deliberately not copied that having only a single output means these
flags are not set by default, because that's something we should be
moving away from in stdenv, but an explicit opt out is still useful,
for example when building in a nix-shell.
@alyssais alyssais marked this pull request as draft September 6, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants