Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: lint setuphooks with ShellCheck #335704

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Aug 18, 2024

Description of changes

This pull reques lints the setup hooks of cmake with ShellCheck, making them more resilient to edge cases such as strings containing white spaces.

Split from #299622

Things done

  • Built on platform(s)
    • x86_64-linux (built cmakeMinimal)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ShamrockLee
Copy link
Contributor Author

@ofborg build cmakeMinimal

@ShamrockLee ShamrockLee marked this pull request as ready for review August 19, 2024 15:54
@FliegendeWurst FliegendeWurst added the needs_reviewer (old Marvin label, do not use) label Nov 13, 2024
@SigmaSquadron SigmaSquadron removed the needs_reviewer (old Marvin label, do not use) label Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants