-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: add missing installPhase hooks #333527
Draft
Sigmanificient
wants to merge
1
commit into
NixOS:staging
Choose a base branch
from
Sigmanificient:add-missing-install-hooks
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
treewide: add missing installPhase hooks #333527
Sigmanificient
wants to merge
1
commit into
NixOS:staging
from
Sigmanificient:add-missing-install-hooks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceabcfc
to
d068e79
Compare
d068e79
to
f39945b
Compare
745690d
to
f45a9c0
Compare
This was referenced Aug 13, 2024
whoops used wrong pr number, dont mind the 2 aboves 😅 |
13 tasks
555004c
to
e898570
Compare
c2d39b6
to
178fbcb
Compare
This was done throw the following command: grep -rP "installPhase =" | cut -d ':' -f 1 \ | xargs -i sh -c "grep -P 'runHook\s+preInstall' {} >/dev/null || echo '{}'" | python add_missing_hooks.py applying the following script: https://gist.github.com/Sigmanificient/c68e03d1ad750a83233c6ab05761cbf2 some manuals adjustments were adding (formatting, edge cases)
178fbcb
to
d3be21e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2.status: merge conflict
This PR has merge conflicts with the target branch
6.topic: cinnamon
Desktop environment
6.topic: dotnet
Language: .NET
6.topic: Enlightenment DE
The Enlightenment Desktop Environment
6.topic: erlang
6.topic: fetch
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: haskell
6.topic: julia
6.topic: jupyter
Interactive computing tooling: kernels, notebook, jupyterlab
6.topic: kernel
The Linux kernel
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
6.topic: lua
6.topic: mate
The MATE Desktop Environment
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: nodejs
6.topic: ocaml
6.topic: pantheon
The Pantheon desktop environment
6.topic: php
6.topic: printing
6.topic: python
6.topic: qt/kde
6.topic: ruby
6.topic: rust
6.topic: steam
Steam game store/launcher (store.steampowered.com)
6.topic: testing
Tooling for automated testing of packages and modules
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: vim
6.topic: vscode
8.has: documentation
This PR adds or changes documentation
8.has: module (update)
This PR changes an existing module in `nixos/`
10.rebuild-darwin: 501+
10.rebuild-darwin: 5001+
10.rebuild-darwin-stdenv
This PR causes stdenv to rebuild
10.rebuild-linux: 501+
10.rebuild-linux: 5001+
10.rebuild-linux-stdenv
This PR causes stdenv to rebuild
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This was done throw the following command:
with the following script:
https://gist.github.com/Sigmanificient/c68e03d1ad750a83233c6ab05761cbf2
2432
hits,68
miss are to be dealt with manuallyApplying the following:
for matching:
and (@emilazy suggestion):
matching:
Extra edits
Some minor adjustment were done to pass green on the CI:
pkgs/build-support/dotnet/dotnetenv/build-solution.nix
stdenv/linux
,glibc
to avoid rebuildingstdenv
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.