freecad: add ifc support

[autra]

Description of changes

This PR adds optional ifc support with ifcopenshell.

It depends on #312381 (fix ifcopenshell build)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[luzpaz]

Just a heads up

• freecad: 0.21.2 → 1.0rc2 #343592

[autra]

Thanks, we shouldn't step too much into each other shoes hopefully ;-)

[autra]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 330190

---

x86_64-linux

[autra]

This is now ready. I took the opportunity to document the different options so that they appear in https://search.nixos.org/ (I hope it's the correct way, if it is, I think all packages should just do that).

[AndersonTorres]

I think all packages should just do that

All packages can't do that. Indeed no package can do that.

This "configuration via input parameters" is too unstable and prone to errors.
#324199

Atemu is experimenting with the module system in #312432 to provide a better experience.

[autra]

@AndersonTorres I added a README. For the option, I see no alternative right now :-)

[autra]

@gebner @AndersonTorres what you guys think about this now?

[AndersonTorres]

Rebase.

[autra]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 330190

[autra]

Rebase.

Done.

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 330190

[GaetanLepage]

I didn't know it was possible/useful to add a README.md file in the package directory.

Diff LGTM though

[autra]

I didn't know it was possible/useful to add a README.md file in the package directory.

I don't think it does anything though, does it? Or maybe I misunderstood?

[GaetanLepage]

I don't think it does anything though, does it? Or maybe I misunderstood?

I guess it doesn't

[GaetanLepage]

LGTM

[GaetanLepage]

Maybe add

passthru = {
  tests = {
    withIfcSupport = freecad.override { ifcSupport = true; };
  };
};

[autra]

Maybe add

passthru = {
  tests = {
    withIfcSupport = freecad.override { ifcSupport = true; };
  };
};

The point is just to compile it once with ifc support during the test phase?

[GaetanLepage]

The point is just to compile it once with ifc support during the test phase?

Exactly

[autra]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 330190

---

x86_64-linux

[autra]

Updated @GaetanLepage @AndersonTorres

[GaetanLepage]

Changes look good. Can you please squash everything in a single commit though ?

[autra]

Changes look good. Can you please squash everything in a single commit though ?

oups, forgot to squash my fixups indeed. Done now.

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 330190

[GaetanLepage]

All good, thanks @autra !

[autra]

Thanks for the reviews @GaetanLepage @AndersonTorres :-)