Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.mdformat-myst: init at 0.2.1 #329919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

python312Packages.mdformat-myst: init at 0.2.1 #329919

wants to merge 1 commit into from
+47 −0

Conversation

mattkang
Copy link
Contributor

@mattkang mattkang commented Jul 25, 2024 •
edited
Loading

Description of changes

Add mdformat_myst Python package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jul 25, 2024
@dotlambda dotlambda changed the title Add mdformat-myst Python package python312Packages.mdformat-myst: init at 0.1.5 Jul 25, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 25, 2024
dotlambda
dotlambda reviewed Jul 25, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to the PR title.
You also need to add the appropriate line to pkgs/top-level/python-packages.nix.

@mattkang mattkang force-pushed the master branch 2 times, most recently from b8f484e to a7bdc55 Compare July 25, 2024 15:59
@mattkang
Copy link
Contributor Author

Thanks @dotlambda for the suggestions! I believe all requested changes have been implemented. Moving PR out of draft.

@mattkang mattkang marked this pull request as ready for review July 25, 2024 16:00
@mattkang mattkang requested a review from natsukium as a code owner July 25, 2024 16:00
@mattkang mattkang force-pushed the master branch 3 times, most recently from bc80fde to cfb265e Compare July 25, 2024 16:18
dotlambda
dotlambda requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't build.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jul 26, 2024
@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Dec 2, 2024
@SigmaSquadron SigmaSquadron removed the awaiting_changes (old Marvin label, do not use) label Jan 5, 2025
@mattkang mattkang force-pushed the master branch 2 times, most recently from ec83422 to e0e2f84 Compare February 19, 2025 04:16
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 19, 2025
@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Feb 21, 2025
@mattkang mattkang changed the title python312Packages.mdformat-myst: init at 0.1.5 python312Packages.mdformat-myst: init at 0.2.1 Feb 21, 2025
@mattkang mattkang self-assigned this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@natsukium natsukium Awaiting requested review from natsukium

Requested changes must be addressed to merge this pull request.

Assignees

@mattkang mattkang

Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mattkang @dotlambda @FliegendeWurst @NixOSInfra @SigmaSquadron