Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkDerivation: don't override meta.position #329900

Closed
wants to merge 1 commit into from

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Jul 25, 2024

This allows derivations to set it manually, which various builders and wrappers do

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This allows derivation to set it manually, which various builders and wrappers do
@pbsds
Copy link
Member Author

pbsds commented Jul 25, 2024

Here is a diff of
nix-env --extra-experimental-features no-url-literals --option system x86_64-linux -f ./. -qaP --json --show-trace --meta --no-allow-import-from-derivation | jq 'to_entries[]|"\(.key): \(.value.meta.position)"' -r | sort

https://gist.github.com/pbsds/ccd24294cd6b77ea0c9f48d01b39abc5

@pbsds
Copy link
Member Author

pbsds commented Jul 25, 2024

I can find both good and bad cases in the diff, i reckon most of the bad ones come from inherit (some-package) meta which now becomes a major foot-gun

@Aleksanaa
Copy link
Member

There is a similar PR: #295973

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jul 25, 2024
@pbsds pbsds marked this pull request as ready for review August 13, 2024 15:56
@pbsds pbsds requested a review from Ericson2314 as a code owner August 13, 2024 15:56
@pbsds
Copy link
Member Author

pbsds commented Aug 13, 2024

closing in favor of #295973

@pbsds pbsds closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: stdenv Standard environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants