Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiout: add output{static,include} #328888

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

multiout: add output{static,include} #328888

wants to merge 2 commits into from

Conversation

SomeoneSerge
Copy link
Contributor

Description of changes

Follow-up to #327114 and #328804

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SomeoneSerge SomeoneSerge requested a review from flokli July 21, 2024 11:30
@github-actions github-actions bot added the 6.topic: lib The Nixpkgs function library label Jul 21, 2024
@SomeoneSerge SomeoneSerge force-pushed the feat/output{Static,Include} branch from af2d266 to 1c895a6 Compare July 21, 2024 11:39
@SomeoneSerge SomeoneSerge mentioned this pull request Jul 21, 2024
Merged
13 tasks
@SomeoneSerge
multiout: add outputInclude
5a5ff50 
So that headers can be deployed separately from propagatedBuild{Inputs,Outputs}
@SomeoneSerge
multiout: add outputStatic
bafc42f
@SomeoneSerge SomeoneSerge force-pushed the feat/output{Static,Include} branch from 1c895a6 to bafc42f Compare July 26, 2024 09:39
@github-actions github-actions bot removed the 6.topic: lib The Nixpkgs function library label Jul 26, 2024
@SomeoneSerge SomeoneSerge changed the title multiout: refactor: inhibit outputBin propagation, add output{Static,Include} multiout: add output{Static,Include} Jul 26, 2024
@ConnorBaker ConnorBaker changed the title multiout: add output{Static,Include} multiout: add output{static,Include} Oct 15, 2024
@ConnorBaker ConnorBaker changed the title multiout: add output{static,Include} multiout: add output{static,include} Oct 15, 2024
@ConnorBaker
Copy link
Contributor

Do we need to do anything special to make include a path dev propagates (or depends on) to avoid breaking existing stuff?

@SomeoneSerge
Copy link
Contributor Author

Do we need to do anything special to make include a path dev propagates (or depends on) to avoid breaking existing stuff?

I don't remember if I actually verified this, but I think we didn't have any in-tree packages which simultaneously use outputInclude and have "include" in their outputs at the time of the change

@SomeoneSerge
Copy link
Contributor Author

@ofborg eval

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flokli flokli Awaiting requested review from flokli

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SomeoneSerge @ConnorBaker