stdenv/generic/setup.sh: extract Make logic #298838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShamrockLee
changed the title
ShamrockLee
force-pushed
the
stdenv-make-logic
branch
from
e65ed59 to
d03a0dd
Compare
ofborg
bot
added
10.rebuild-darwin-stdenv
ofborg
bot
added
11.by: package-maintainer
13 tasks
ShamrockLee
force-pushed
the
stdenv-make-logic
branch
from
d03a0dd to
89b3174
Compare
ShamrockLee
force-pushed
the
stdenv-make-logic
branch
2 times, most recently
from
4b3e961 to
a3194f2
Compare
|
@ofborg build apptainer singularity |
|
Test cases produced with @ofborg build tests.testers.runNixOSTest-example |
wegank
added
the
2.status: merge conflict
ShamrockLee
force-pushed
the
stdenv-make-logic
branch
from
a3194f2 to
e94014f
Compare
|
Rebased it and resolved the merge conflict. |
ofborg
bot
removed
the
2.status: merge conflict
Extract Make-related logics into separate functions.
- Bash functions to call configure-script-related logics
- scriptConfigure
- Bash functions to call the make-related logics
- makeBuild
- makeCheck
- makeInstall
- makeInstallCheck
- makeDist
- Benefits:
- Increase reusability. If applied, developers can call them from
their pre* or post* phases when using language- or
framework-specific build helpers that overwrites those Make-based
phases.
|
Renamed |
ShamrockLee
force-pushed
the
stdenv-make-logic
branch
from
e94014f to
cfa7ed2
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/mix-workflows-by-extracting-build-commands-from-each-stages/48376/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Extract
Make-basedbuild process into separated Bash functions to make them reusable by packages, making them reusable by packages using a language- or framework-specific build helpers that rewrite the phases.Proposed Bash functions containing the make-related logic:
Name each Make-based phasesWithhold due to the scale of fixes regarding the wide-spread "phases are Bash function" assumption. See #299045.make*Phaseand specify*Phase=make*Phaseby default. This makes it align with build process based on other build tools such as CMake.Use
apptaineras an example how packages usingbuildGoModulecould benefit from the Make-based build commands provided bystdenv.mkDerivation.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.