Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

psychopy: init at 2023.2.4 #274862

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

psychopy: init at 2023.2.4 #274862

wants to merge 1 commit into from

Conversation

auroraanna
Copy link
Contributor

@auroraanna auroraanna commented Dec 17, 2023 •
edited
Loading

Description of changes

  • added package psychopi

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@auroraanna auroraanna self-assigned this Dec 17, 2023
@auroraanna auroraanna added the 8.has: package (new) This PR adds a new package label Dec 17, 2023
@auroraanna
Copy link
Contributor Author

waiting for hydra to build openai-triton-llvm-17.0.0-c5dede880d17 because my machine ran out of memory to build it.

@auroraanna auroraanna added the 2.status: blocked by pr/issue Another PR or issue is preventing this from being completed label Dec 17, 2023
@auroraanna auroraanna force-pushed the psychopy branch 3 times, most recently from 4302c14 to 443c430 Compare December 18, 2023 16:58
@auroraanna
Copy link
Contributor Author

So, currently it just exits with 1, no stderr or stdout.
strace ./result/bin/psychopy 2>&1 | grep "No such file or directory" shows lots of missing libraries and other glibc files. lots of these are for graphical purposes. the graphics related libraries in psychopy seem to be wxPython psychtoolbox and ffpyplayer but no psychotoolbox tests are run. it tells you to use some "tox" for testing now.

bcdarwin
bcdarwin suggested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@bcdarwin bcdarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work towards getting psychopy integrated. I've left a few preliminary comments, but it's likely there is still quite a bit of work to do to get these packages to a working state.

pkgs/applications/science/psychopy/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/psychopy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/dukpy/default.nix
};
format = "setuptools";
doCheck = false;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add pythonImportsCheck = [ ... ] to Python packages.

pkgs/development/python-modules/psychtoolbox/default.nix
substituteInPlace PsychSourceGL/Source/Common/Screen/PsychWindowSupport.c \
--replace "libusb-1.0.so.0" "${libusb}/lib/libusb-1.0.so.0"
'';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Python packages, please either properly enable the tests e.g. by adding pytestCheckHook to nativeCheckInputs or explicitly disabling them with some explanation in comment.

pkgs/development/python-modules/ffpyplayer/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/psychopy/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/ffpyplayer/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/psychtoolbox/default.nix Show resolved Hide resolved
pkgs/top-level/python-packages.nix Show resolved Hide resolved
pkgs/applications/science/psychopy/default.nix Outdated Show resolved Hide resolved
@auroraanna auroraanna force-pushed the psychopy branch 3 times, most recently from 2746e3f to 6835623 Compare December 21, 2023 11:46
@auroraanna
Copy link
Contributor Author

aaa, psychtoolbox has so many licenses, some of which are not in nixpkgs

@bcdarwin
Copy link
Member

aaa, psychtoolbox has so many licenses, some of which are not in nixpkgs

In this case I would set licenses = [ lib.licenses.unfree ]; (since some of them have non-commercial clauses).

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 20, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin bcdarwin requested changes

Assignees

@auroraanna auroraanna

Labels
2.status: blocked by pr/issue Another PR or issue is preventing this from being completed 2.status: merge conflict This PR has merge conflicts with the target branch 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@auroraanna @bcdarwin @wegank