Fix cross-compilation of firefox for powerpc64le-unknown-linux-musl (take two) #254641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the multibitdepth cmake invocations didn't use cmakeFlags. This meant that they didn't get the flags added by stdenv for cross compilation, and so they didn't cross compile. To fix this, add cmakeCommonFlags into cmakeFlags, and then add all the non-common flags to cmakeFlagsArray after the multibitdepth stuff has been built. As a consequence of this change, we also no longer need to disable asm for RISC-V.
autotools seems to have issues around vsnprintf when compiling with fortification on powerpc64-musl. this problem doesn't appear on other platforms, or when using cmake.
ofborg
bot
added
6.topic: cross-compilation
12 tasks
wegank
added
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
depends on #233470 with an additional fixup patch
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)