Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boost: apply upstream fix for boost::phoenix ODR violation found in 1… #254578

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

zeuner
Copy link
Contributor

@zeuner zeuner commented Sep 11, 2023

….81-1.83

Description of changes

Upstream boost::phoenix leads to linker errors since 1.81: boostorg/phoenix#111, freeorion/freeorion#4707. This PR is for applying the upstream commit that fixes it. Not fixing it leads to packages that use affected boost::phoenix features having to build on an older boost version. For shared libraries (e.g.

), this can lead to conflicts when reverse dependencies use a different boost version.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@zeuner
Copy link
Contributor Author

zeuner commented Sep 11, 2023

Comment from maintainer @hjones2199 appreciated.

@FliegendeWurst
Copy link
Member

Please rebase instead of merging remote branches.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 18, 2024
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants