Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avalanche-cli: init at 1.8.0 #238096

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

avalanche-cli: init at 1.8.0 #238096

wants to merge 1 commit into from

Conversation

BriungRi
Copy link

@BriungRi BriungRi commented Jun 16, 2023 •
edited
Loading

Description of changes

This PR adds avalanche-cli to nixpkgs. This is my first submission, so I am sure there are mistakes. Please offer me feedback/review if you see necessary changes!

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 16, 2023
@wegank
Copy link
Member

wegank commented Jun 16, 2023

It's best to build the package from source, following go.section.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 16, 2023
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 19, 2024
@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Nov 5, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 5, 2024
@wegank wegank changed the title Add avalanche-cli avalanche-cli: init at 1.8.0 Dec 5, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 5, 2024
@wegank wegank removed the awaiting_changes (old Marvin label, do not use) label Dec 5, 2024
@wegank
Copy link
Member

wegank commented Dec 5, 2024

Reworked (and trying something new from #355973).

@FliegendeWurst FliegendeWurst added the 9.needs: maintainer Package or module needs active maintainers label Dec 30, 2024
@FliegendeWurst FliegendeWurst marked this pull request as draft January 28, 2025 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 9.needs: maintainer Package or module needs active maintainers 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BriungRi @wegank @FliegendeWurst @Janik-Haag