Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

np2kai: Fix build #200256

Merged
merged 1 commit into from
Nov 9, 2022
Merged

np2kai: Fix build #200256

merged 1 commit into from
Nov 9, 2022

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Nov 8, 2022

ZHF: #199919

Description of changes

Treewide removal of -l$NIX_BUILD_CORES in #192447 incorrectly removed a closing brace here, which broke the build.

Builds on x86_64-linux & works - np21kai shown here.
Bildschirmfoto von 2022-11-08 21-23-22

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@raphaelr raphaelr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 200256 run on x86_64-linux 1

1 package built:
  • np2kai

@mweinelt mweinelt merged commit 6d753dd into NixOS:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants