treewide: patchPhase -> postPatch

[smancill]

Description of changes

This is the first of three trewide PRs I've been working on to reduce unnecessary overriding of phases.

I don't see a good reason for a derivation to override patchPhase unless they are applying external patches in a custom way.

Use postPatch like most of other derivations applying changes to the sources. All changes were done manually to check the content of the phase before moving it to a hook.

Before this patch:

$ rg 'postPatch =' pkgs | wc -l
    3658
$ rg 'patchPhase =' pkgs | wc -l
     357

After this patch:

$ rg 'postPatch =' pkgs | wc -l
    3974
$ rg 'patchPhase =' pkgs | wc -l
      49

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[smancill]

Ugh, I broke something:

       at /Users/smancill/.cache/nixpkgs-review/rev-6ad63c1aa2a0514af04bf87f94dd0331bc82b608/nixpkgs/pkgs/development/libraries/hspell/dicts.nix:4:44:

            3| let
            4|   dict = variant: a: stdenv.mkDerivation ({
             |                                            ^
            5|     inherit (hspell) version src patchPhase nativeBuildInputs;

       … while evaluating the attribute 'patchPhase' of the derivation 'aspell-dict-he-1.1'

I'll mark it as draft while I fix it.