libstore+nix-build: add load-limit setting and use its value for NIX_LOAD_LIMIT en var #8105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LOAD_LIMIT env var Aimed at solving issue NixOS#7091 Signed-off-by: Antoine Viallon <[email protected]>
emilazy
added a commit
to emilazy/nix
that referenced
this pull request
Jul 20, 2024
Closes: NixOS#7091 Closes: NixOS#6855 Closes: NixOS#8105 Co-authored-by: Alex Wied <[email protected]>
emilazy
added a commit
to emilazy/nix
that referenced
this pull request
Jul 20, 2024
Closes: NixOS#7091 Closes: NixOS#6855 Closes: NixOS#8105 Co-authored-by: Alex Wied <[email protected]>
emilazy
added a commit
to emilazy/nix
that referenced
this pull request
Jul 20, 2024
Closes: NixOS#7091 Closes: NixOS#6855 Closes: NixOS#8105 Co-authored-by: Alex Wied <[email protected]>
|
Linking #11143 here for any subscribers to this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7091
Motivation & Context
As explained in issue #7091, NixOS/nixpkgs#192447 removed
-lflag from all buildsystem invocations in nixpkgs, in order to improve Hydra efficiency.However, this had several drawbacks, as this removed the ability to limit CPU load, causing OOM issues or extreme system loads in some bad scenarios (
ninjabuildsystem building something with-flto=autoenabled).This patch aims to reintroduce the possibility to limit system load (together with PR NixOS/nixpkgs#192799), while still allowing Hydra to have full build efficiency.
Checklist for maintainers
Maintainers: tick if completed or explain if not relevant
tests/**.shsrc/*/teststests/nixos/*Priorities
Add 👍 to pull requests you find important.