Set FD_CLOEXEC on sockets created by curl #12439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxHearnden
requested review from
Ericson2314 and
fricklerhandwerk
as code owners
Curl creates sockets without setting FD_CLOEXEC/SOCK_CLOEXEC, this can cause connections to remain open forever when using commands like `nix shell` This change sets the FD_CLOEXEC flag using a CURLOPT_SOCKOPTFUNCTION callback.
roberth
approved these changes
Feb 10, 2025
| @@ -300,6 +300,14 @@ struct curlFileTransfer : public FileTransfer | |||
| return ((TransferItem *) userp)->readCallback(buffer, size, nitems); | |||
| } | |||
|
|
|||
| #if !defined(_WIN32) && LIBCURL_VERSION_NUM >= 0x071000 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Curl creates sockets without setting FD_CLOEXEC/SOCK_CLOEXEC, this can cause connections to remain open forever when using commands like
nix shellThis change sets the FD_CLOEXEC flag using a CURLOPT_SOCKOPTFUNCTION callback.
Context
This is implemented based on comments in curl/curl#2252
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.